CMake: StringProcessing Apple Caches #85073
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding caches for Apple-style builds for the StringProcessing library.
etcwilde
requested review from
compnerd,
edymtt and
justice-adams-apple
as code owners
|
@swift-ci please smoke test |
compnerd
approved these changes
Oct 23, 2025
edymtt
approved these changes
Oct 28, 2025
| set(SwiftStringProcessing_ARCH_SUBDIR arm64 CACHE STRING "") | ||
| set(SwiftStringProcessing_PLATFORM_SUBDIR freestanding CACHE STRING "") | ||
| set(CMAKE_BUILD_TYPE MinSizeRel CACHE STRING "") | ||
| set(SwiftStringProcessing_SINGLE_THREADED_MODE YES CACHE BOOL "") |
There was a problem hiding this comment.
I would get rid of this setting, as it makes sense only for Synchronization
Suggested change
| set(SwiftStringProcessing_SINGLE_THREADED_MODE YES CACHE BOOL "") |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding caches for Apple-style builds for the StringProcessing library.